Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LoggingTest build on some platforms with some build config #2641

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

SergeyRyabinin
Copy link
Contributor

@SergeyRyabinin SergeyRyabinin commented Aug 28, 2023

Issue #, if available:

LoggingTest.cpp:90:18: error: null destination pointer [-Werror=format-truncation=]
         vsnprintf(outputBuff.GetUnderlyingData(), requiredLength, formatStr, args);
         ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Some gcc versions seem to not like our Aws::Array container.
Description of changes:
Add explicit check for pointer to be allocated.
Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SergeyRyabinin SergeyRyabinin marked this pull request as ready for review August 28, 2023 20:33
@SergeyRyabinin SergeyRyabinin merged commit c26bae4 into main Aug 28, 2023
4 checks passed
@SergeyRyabinin SergeyRyabinin deleted the sr/fixLoggingTestBuild branch August 28, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants